Charge Control C: add section regarding phase count switching support #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
t-mon
requested changes
Jan 14, 2025
Contributor
t-mon
left a comment
t-mon
left a comment
There was a problem hiding this comment.
Otherwise lgtm, I actually don't see the diff in most pictures here, but that also could be the pr-review view. Have all those images changed?
Member
Author
No, I just adjusted the permissions. |
mhei
force-pushed
the
everest/charge_control_c-switch-3ph1ph
branch
from
d2ccd0d to
9199262
Compare
FaHaGit
reviewed
Jan 14, 2025
| * **none** (default): No phase-count switching is supported - only R1/S1 is used to switch on/off a single contactor. | ||
| * **serial**: Phase-count switching support is enabled using the serial wiring as described above: R1/S1 switches | ||
| the primary contactor, R2/S2 is attached to the secondary contactor. | ||
| * **mutual**: Phase-count switching support is enabled using the mutual wiring as described above. R1/S1 is wired to |
Contributor
There was a problem hiding this comment.
"mutual" is currently not supported or? We should mention it in the documentation.
mhei
force-pushed
the
everest/charge_control_c-switch-3ph1ph
branch
from
9199262 to
f8654be
Compare
mhei
force-pushed
the
everest/charge_control_c-switch-3ph1ph
branch
from
f8654be to
bf438e8
Compare
Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
mhei
force-pushed
the
everest/charge_control_c-switch-3ph1ph
branch
from
bf438e8 to
771af5e
Compare
…cumentation Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
FaHaGit
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.