Fix OpenCheckoutOptions Type per Documentation#5
Open
sators wants to merge 2 commits intochargebee:mainfrom
Open
Fix OpenCheckoutOptions Type per Documentation#5sators wants to merge 2 commits intochargebee:mainfrom
sators wants to merge 2 commits intochargebee:mainfrom
Conversation
cb-suvrodeep
approved these changes
Feb 12, 2025
|
@cb-suvrodeep any updates on this? this repository seems not to be maintained so often. I would want to contribute but I hesitated when saw this PR waiting to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The openCheckout documentation shows most parameters as optional, and the
hostedPageparameter requiring a Promise with a hosted page object to be returned. This PR aligns the types with that documentation.