Update Cryptography package to version 46.0.0 #1375
Conversation
|
Have you built this version and tested it with the pkgtest app, as described in the README? If so, which Python versions and ABIs have you checked? You don't need to cover every combination, but you should test at least one before submitting a PR, and let me know the details. |
|
If you want to proceed with this, please respond to my previous comments, and I'll reopen the PR. |
IsakTheHacker
changed the title
|
Could you reopen this PR for me? |
|
I have built and tested using Python 3.12 on x86_64 and arm64-v8a. The build succeeds and the tests in pkgtest succeed. The patches have been corrected to work with the newest version of Cryptography. This PR is ready to be merged now. One thing to note is that I have pulled the changes from #1413 since I thought they would help me when I was struggling. I am not sure if those are necessary for this PR but you should merge that PR before mine. Other discussion perhaps, but why are the new wheels built with android-24 and not android-21 like it used to be. Is there any actual reason that we can't continue publishing wheels that work on newer versions while they continue to be backwards-compatible with older versions of chaquopy. I understand that API 24 is now the minimum in Chaquopy (which makes development easier since we could remove patches etc etc etc...) but what complexity issue are we solving by marking the new wheels as android-24 plus only. I would love if you could build this package for android-21 instead! |
Newer versions require cffi 2.0.0. By using a slightly older version we can get by with cffi 1.17.1 which is already patched and published to the package repository
|
I encountered some additional issues. Accidentally, I had forgotten to pass my custom |
IsakTheHacker
changed the title
If the wheels are marked as compatible with android-21, then they must be tested on android-21, and this can't be done with the current version of Chaquopy. Having to test with different versions of Chaquopy would make the package test process even more time-consuming than it already is. So if I have to pick one, it should be the current one, because that's what the most people will be using. Why do you need to support devices which are more than 9 years old? |
OK, I'll try to do that now. If you find that the changes aren't necessary for this PR after all, then you can remove them to unblock it. |
2 participants
There are some Python packages that depend on version 44 or newer so an update to Cryptography would be highly appreciated. I've also heard that there has been some vulnerability affecting version 43 and lower but I have not looked into that any further at this time.