Fix semantic bug in limitscope() #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a problem with the logic in the if else statements from lines 94 to 101 prior to this commit: In case the rule of self is 'bidirectional', the if statement on line 94-95 evaluates to true. The code following this statement will update the scope of self only if obj is downstream of self in the sequence. But for bidirectional, the scope also has to be updated if obj is upstream of self. This was meant to happen in the next elif statement. However: the conditional of line 98-99 is an elif statement. This leads to that this code is skipped if the self.rule is bidirectional, since the if block of line 94-95 evaluated to true. So if the bidirectional terminate modifier (obj) is upstream of the tagobject (self) it should modify, that tagobject's (self) scope won't be modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a problem with the logic in the if else statements from lines 94 to 101 prior to this commit:
In case the rule of self is 'bidirectional', the if statement on line 94-95 evaluates to true. The code following this statement will update the scope of self only if obj is downstream of self in the
sequence. But for bidirectional, the scope also has to be updated if obj is upstream of self. This was meant to happen in the next elif statement.
However: the conditional of line 98-99 is an elif statement. This leads to that this code is skipped if the self.rule is bidirectional, since the if block of line 94-95 evaluated to true.
So if the bidirectional terminate modifier (obj) is upstream of the tagobject (self) it should modify, that tagobject's (self) scope won't be modified.