-
Notifications
You must be signed in to change notification settings - Fork 54
Add HashiCorp Vault Manager #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ebc99aa to
c4147d8
Compare
|
Missed some things that are fixed now. Poetry.lock was rebuilt, changelog included. @jjmerchante @sduenas (mentioning you both cause I can't ask for reviews through the UI and I don't know if this got anywhere) (sorry for delay was a crazy week) |
sduenas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PR looks ok but I'm suggesting some minor changes. Nothing related with how the code works.
c4147d8 to
4f49daa
Compare
Signed-off-by: Alberto Ferrer Sánchez <alberefe@gmail.com>
4f49daa to
3c9cc93
Compare
|
The changes have been done. I can't find a way to get that poetry.lock conflict out of the way. I have remade the poetry.lock file several times and tried this: rm poetry.lock That apparently worked in the other PR but doesn't here? |
Implement credential management system with Hashicorp Vault integration. This provides automated secrets retrieval.
This relieves the user from hardcoding credentials in files and also automates the retrieval of api keys from pools in an automated way, optimizing speed when the program needs to rotate through several api keys or credentials to access different services in a row.
It follows the same idea of Bitwarden Manager class, but using other service.
The following are the contents of the PR: