-
Notifications
You must be signed in to change notification settings - Fork 3
Enhance GUI and benchmarking tools for COBA performance analysis; #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
10484eb
update gui and csv record
Hepbmstl 1ab1f62
Update for recorder and COBA test
Hepbmstl 065c8d8
update_homo
Hepbmstl 866d503
temp save
Hepbmstl 22a37fc
Align to main
Hepbmstl e0d1ccb
Replace unbranch with wpr
Hepbmstl 84b22c0
temp save
Hepbmstl c2515ee
CsvOutput and fixed coba benchmark.
Hepbmstl e27924c
align to ori_main
Hepbmstl 0ee0f95
fix_little_bug
Hepbmstl c6e98ed
Can choose the sparsity level to closer to the memory boundary
Hepbmstl f762ef2
Merge remote-tracking branch 'origin/main' into dev-fcn-optimizing
Hepbmstl 8354fb4
Add benchmarking scripts and performance boundary analysis tools
Hepbmstl fad5449
Update fcnmv homo type scatter
Hepbmstl c1f1999
Check the boolean type
Hepbmstl e9b95e7
Restructure the file structure
Hepbmstl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk):
spk_fconstruction is inconsistent and appears unused/incorrectly overwritten.In the non-
transposebranch,spk_fis first built as a float mask and then immediately replaced byu.math.asarray(spikes, dtype=bool), making the earlier construction dead code. Also, in the shown snippetspk_fis never used, so the conversion appears to have no effect.Please either:
spk_fconstruction and keep only the representation actually needed, orspk_fis the value converted and passed into the kernel if that’s what the kernel expects.Aligning this with the kernel’s expected type will avoid subtle type/semantics issues and confusion from unused variables.