Conversation
…vice - Introduce #[BindsFrom] attribute for BindView subclasses to declare source classes, enabling targeted cache warming instead of N² pairs - Convert BindUtils from singleton with static state to a proper DI service with instance properties and public constructor - Add BindView::setBindUtils() static bridge for DI integration with fallback to standalone usage - Simplify SetVersionSubscriber to inject BindUtils directly - Deduplicate type validation by extracting shared static methods from BindUtils, fixing missing isAutoConfigurableType() check in cache warmer - Convert ReflectionService from static to instance storage - Remove all reflection-based test state resets Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[BindsFrom]attribute for BindView subclasses to declare source classes, enabling targeted cache warming instead of N² pairsBindUtilsfrom singleton with static state to a proper DI service with instance properties and public constructorBindView::setBindUtils()static bridge for DI integration with fallback to standalone usageSetVersionSubscriberto injectBindUtilsdirectlyBindUtils, fixing missingisAutoConfigurableType()check in cache warmerReflectionServicefrom static to instance storageTest plan
composer test)composer analyse)composer cs-check)composer bench)🤖 Generated with Claude Code