Conversation
Add static analysis (PHPStan at max level) and code style checking (PHP-CS-Fixer with @PER-CS/@symfony presets) as composer scripts and CI steps. Fix all 117 PHPStan errors across the codebase without relying on a baseline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self::overstatic::for private statics,instanceofnarrowing for reflection types, type-safe cache loadingcomposer analyse,composer cs-check, andcomposer cs-fixscriptsTest plan
composer run-script analyse— PHPStan passes at max level (0 errors)composer run-script cs-check— PHP-CS-Fixer reports 0 fixable filescomposer run-script test— all 87 tests pass (326 assertions)🤖 Generated with Claude Code