Conversation
NavigationFactory was caching all NavigationInterface instances by ::class, causing all ClosureNavigation instances to share the same cached result regardless of their content. Add isCacheable(): bool to NavigationInterface: - AbstractNavigation returns false (no caching by default) - AbstractCachedNavigation returns true - ClosureNavigation returns true only when explicit cacheKey is provided NavigationFactory skips the cache entirely for non-cacheable navigations, building the menu tree fresh on every call.
In FrankenPHP worker mode, services are singletons shared across requests. Symfony calls services_resetter->reset() (via Kernel::boot) between requests for services implementing ResetInterface. Without reset: - NavigationFactory::$built persists the same Item objects across requests - Matcher's SplObjectStorage caches Item→active state by object identity - Result: first request's active menu item is frozen for all subsequent requests Fix: NavigationFactory::reset() clears $built; Matcher::reset() clears cache. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
wtorsi
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NavigationFactory was caching all NavigationInterface instances by ::class, causing all ClosureNavigation instances to share the same cached result regardless of their content.
Add isCacheable(): bool to NavigationInterface:
NavigationFactory skips the cache entirely for non-cacheable navigations, building the menu tree fresh on every call.