Conversation
- require symfony ^8.0, php ^8.5 - update CI workflows: actions/checkout@v6, actions/cache@v5, ext-ds install, hardened cache key, initial tag v8.0.0, cs-check step added - track .claude/ config Bug fixes: - ClosureNavigation: use Closure::fromCallable() to safely wrap any callable - NavigationFactory: replace array_merge_recursive with array_replace for options to prevent scalar 'namespace' from being coerced into an array - RouteVoter: remove incorrect case-insensitive 'i' and redundant 'u' regex flags Performance: - RouteVoter: cache current request route/params per request instance to avoid redundant attribute lookups across items in the same render - Matcher::clear(): call removeAll() instead of allocating a new SplObjectStorage Code quality: - NavigationFactory::createCacheKey: use $nav::class instead of get_class() - Accessor::hasAccessToItem: use Map::put() consistently - MenuExtension: remove getName() — no-op since Twig 3 - NavigationInterface: remove redundant PHPDoc duplicating typed signature composer.json: - remove hardcoded "version" field (breaks Packagist tag-based versioning) - add "homepage" field, expand keywords, improve description README: - add PHP / Symfony / License / CI badges - fix requirements table: symfony/* ^8.0 - fix hasAccess() docs: AND logic for roles, not OR - fix configureCacheItem() example: use Symfony\Contracts\Cache\ItemInterface - fix hasAccessToChildren() signature in Twig reference Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.