change compress to tar.gz for linux/mac#51
Merged
andelf merged 1 commit intoch32-rs:mainfrom Jun 27, 2024
Merged
Conversation
Contributor
|
Since all the code has not changed, I've uploaded the new assets using The folder structure is not changed. I'll add a checksum file to the tarballs later. |
Contributor
Author
|
@andelf thank you, that is more than enough :) |
Contributor
Author
|
PS: we have made PR to use your awesome wchisp tool to ch32 arduio, tested and working well. Though still need manual hold BOOT high while reset currently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi sorry for not doing this from beginning.
This is follow up to #49 to change the compress tool to tar.gz for linux/macos. The reason is that arduino IDE after download and unzip, the wchisp is marked as not executable. Look like x permission is not reserved by Arduino with .zip in linux and can cause headache to user. Chaning to tarball resolve this issue.
Also update softprops/action-gh-release to v2 to fix ci warning
PS: if possible could you please make another release, sorry for the inconvenience :)