fix: add support for incompatible_no_implicit_file_export flag#596
Merged
fix: add support for incompatible_no_implicit_file_export flag#596
Conversation
cgrindel
force-pushed
the
gh566_no_implicit_file_export
branch
from
ac87226 to
cc9ee7c
Compare
Owner
Author
|
@Mergifyio queue |
Contributor
🟠 Waiting for conditions to matchDetails
|
Contributor
Merge Queue Status🟠 Waiting for queue conditions Required conditions to enter a queue
|
cgrindel
force-pushed
the
gh566_no_implicit_file_export
branch
from
cc9ee7c to
4c93677
Compare
Add explicit exports_files() declarations to all packages that reference .bzl files across package boundaries to comply with Bazel's incompatible_no_implicit_file_export flag. Changes: - Enable incompatible_no_implicit_file_export flag in shared.bazelrc - Add exports_files() for defs.bzl in bazeldoc, bzlformat, bzllib, bzlrelease, bzltidy, ci, markdown, and updatesrc packages - Add exports_files() for execute_binary.bzl in shlib/rules - Upgrade buildifier_prebuilt to 8.2.1.1 for compatibility - Add explicit rules_python 1.8.0 dependency to override transitive dependency on 1.0.0 (includes PR #3471 fix) Fixes #566 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
cgrindel
force-pushed
the
gh566_no_implicit_file_export
branch
from
4c93677 to
19e3f56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for Bazel's
--incompatible_no_implicit_file_exportflag to comply with the new visibility requirements for file exports.Changes
incompatible_no_implicit_file_exportflag inshared.bazelrcexports_files()declarations for all.bzlfiles referenced across package boundaries:bazeldoc/BUILD.bazel- exportsdefs.bzlbzlformat/BUILD.bazel- exportsdefs.bzlbzllib/BUILD.bazel- exportsdefs.bzlbzlrelease/BUILD.bazel- exportsdefs.bzlbzltidy/BUILD.bazel- exportsdefs.bzlci/BUILD.bazel- exportsdefs.bzlmarkdown/BUILD.bazel- exportsdefs.bzlupdatesrc/BUILD.bazel- exportsdefs.bzlshlib/rules/BUILD.bazel- exportsexecute_binary.bzlbuildifier_prebuiltfrom7.3.1to8.2.1.1for compatibilityrules_python1.8.0dependency to override transitive1.0.0(includes PR #3471 fix)Test Plan
bazel test //...Related Issues
Fixes #566
🤖 Generated with Claude Code