Support configuring filesystem root from environment#8
Open
bobf wants to merge 2 commits intocgoldberg:masterfrom
Open
Support configuring filesystem root from environment#8bobf wants to merge 2 commits intocgoldberg:masterfrom
bobf wants to merge 2 commits intocgoldberg:masterfrom
Conversation
Create a `Path` class which provides paths for various locations joined to an optionally-configurable custom filesystem root via environment variable `LINUX_METRICS_ROOT_FS`, defaulting to `/` Add tests for new class and make existing tests more precise by using a test filesystem containing exact, predetermined values. Remove dependency on Linux file system for development/running tests. Support running in a container with requisite directories mounted to a custom mount-point within the container.
bobf
force-pushed
the
configurable-filesystem-root
branch
from
baaac22 to
36e7046
Compare
Provide the following:
Field 9 -- # of I/Os currently in progress
The only field that should go to zero. Incremented as requests are
given to appropriate struct request_queue and decremented as they finish.
Field 10 -- # of milliseconds spent doing I/Os
This field increases so long as field 9 is nonzero.
Field 11 -- weighted # of milliseconds spent doing I/Os
This field is incremented at each I/O start, I/O completion, I/O
merge, or read of these stats by the number of I/Os in progress
(field 9) times the number of milliseconds spent doing I/O since the
last update of this field. This can provide an easy measure of both
I/O completion time and the backlog that may be accumulating.
[https://www.kernel.org/doc/Documentation/iostats.txt]
bobf
force-pushed
the
configurable-filesystem-root
branch
from
36e7046 to
8e65eed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a
Pathclass which provides paths for various locations joinedto an optionally-configurable custom filesystem root via environment
variable
LINUX_METRICS_ROOT_FS, defaulting to/Add tests for new class and make existing tests more precise by using a
test filesystem containing exact, predetermined values.
Remove dependency on Linux file system for development/running tests.
Support running in a container with requisite directories mounted to a
custom mount-point within the container.