Fix: raise TypeError instead of return TypeError#22
Merged
cgiovanetti merged 1 commit intomainfrom Jan 26, 2026
Merged
Conversation
BUG: Line 161 used `return TypeError(...)` instead of `raise TypeError(...)`. This meant that when a Reaction was created without either spline_data or frwrd_rate_param_func, the __init__ method would: 1. Return a TypeError instance (which is truthy, not an error) 2. Allow object construction to "succeed" 3. Cause cryptic failures later when the object is used The fix changes `return` to `raise` so invalid Reaction construction properly fails with a clear error message. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bug
File:
linx/reactions.py, line 161This returns a TypeError instance instead of raising it.
Impact
When a
Reactionis created without providing eitherspline_dataorfrwrd_rate_param_func:__init__returns aTypeErrorobject (which is truthy, not an error)Example of the problem
The Fix
Change
return TypeError(...)→raise TypeError(...)🤖 Generated with Claude Code