Fixing two issues with latest Node JS #7
Open
jsastriawan wants to merge 2 commits intocgbystrom:masterfrom
Open
Fixing two issues with latest Node JS #7jsastriawan wants to merge 2 commits intocgbystrom:masterfrom
jsastriawan wants to merge 2 commits intocgbystrom:masterfrom
Conversation
ExistsSync has been moved to fs for latest Node js
Apparently recent nodejs is very picky about referring module without .js
Doesn't build under Do you have ANY version which generated a good I wanted to upgrade this to use Promises and ES6 (for fun?) but can't get it out of this GOD AWFUL CoffeeScript. There's something funky in the updateMany section that CoffeeScript does not even like even when it's the sole function in the file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Carl,
I am interested to use Hoard time series database as a storage for upcoming features I am working on Meshcentral. However I discover two issues, one is related to path.fileExistsSync that has been moved to fs.fileExistsSync and buffer_ieee754 reference (adding .js) extension.
I made this two changes and it seems working well with Node JS 6.10.1. Please merge this so that we can get a working Hoard library.
Regards,
Joko Sastriawan