fix(dashboard): stop auto-archiving Done/Cancelled tasks in UI filter#147
Open
mvanhorn wants to merge 1 commit intocft0808:mainfrom
Open
fix(dashboard): stop auto-archiving Done/Cancelled tasks in UI filter#147mvanhorn wants to merge 1 commit intocft0808:mainfrom
mvanhorn wants to merge 1 commit intocft0808:mainfrom
Conversation
The isArchived() function treated all Done/Cancelled tasks as archived, hiding them from the active view immediately on completion. This caused tasks with incomplete progress to appear archived prematurely. Change isArchived() to only check the explicit archived flag, matching the server-side archival logic. Done tasks now stay visible until the user explicitly archives them. Fixed in both dashboard/dashboard.html and edict/frontend/src/store.ts. Note: dashboard/dist/ needs a rebuild (npm run build) to pick up the React source change. Closes cft0808#54 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isArchived()fromt.archived || ['Done','Cancelled'].includes(t.state)to!!t.archivedin bothdashboard/dashboard.htmlandedict/frontend/src/store.tshandle_archive_task(which setst.archived = Trueas a separate flag from state)Evidence: Issue #54 reports a task at 20% progress already showing as archived. The
isArchived()function was treating all Done/Cancelled tasks as archived, but the "archive all done" button at line 995 proves Done tasks can exist without being archived (!t.archived && ['Done','Cancelled'].includes(t.state)). The server-sidehandle_archive_task(line 144-166) also treats archival as a separate explicit action from state transitions.Note:
dashboard/dist/assets/index-J5u1Q_A5.jsis a pre-built bundle and needs a rebuild (cd edict/frontend && npm run build) to pick up the React source change.Closes #54
Test plan
kanban_update.py state JJC-TEST Done "test", verify it stays in "active" filter on the dashboardcd edict/frontend && npm run build