cleanup and add "trailing_zeroes" argument to si_format()#8
Open
machineonamission wants to merge 5 commits intocfobel:masterfrom
Open
cleanup and add "trailing_zeroes" argument to si_format()#8machineonamission wants to merge 5 commits intocfobel:masterfrom
machineonamission wants to merge 5 commits intocfobel:masterfrom
Conversation
machineonamission
commented
Jan 23, 2022
- some random fixes that pycharm wanted me to do
- add strip() calls to si_format(). before, if the prefix was nothing there could be a trailing space
- add trailing_zeroes argument which uses different formatting techniques to include or exclude trailing zeroes (i.e. the 0 in 1.20)
|
"before, if the prefix was nothing there could be a trailing space" That is the correct behavior. A space is always required between the value and the unit, even if no prefix is used: "The numerical value always precedes the unit and a space is always used to separate the Source: https://www.bipm.org/documents/20126/41483022/SI-Brochure-9-EN.pdf For this to be applied consistently, e.g. when directly concatenating the output of si_format() with a unit symbol, the space must be included even when no prefix is used. For example: This is the correct, expected, and consistent behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.