Skip to content

allow the policies defined in same template, add parameter for blocki…#30

Open
cmurphy23 wants to merge 2 commits intocfn-modules:masterfrom
cmurphy23:master
Open

allow the policies defined in same template, add parameter for blocki…#30
cmurphy23 wants to merge 2 commits intocfn-modules:masterfrom
cmurphy23:master

Conversation

@cmurphy23
Copy link

Potential fix for #28. This time we keep the bucket policies and make sure they are allowed.

See this post for more information: https://awstip.com/aws-breaking-change-news-new-s3-buckets-blocked-for-public-access-ad83d626afb4

@michaelwittig
Copy link
Contributor

@cmurphy23 It might be possible to avoid the extra parameter. Would #31 work for your use case as well?

@cmurphy23
Copy link
Author

If I understand correctly, this will allow bucket policies to be created if and only if the Access variable is set to PublicRead, which will create a policy that allows everyone to read the bucket, which may not be desirable. The reason I made a new variable in this PR is to allow bucket policies to be created without automatically opening up the bucket to everyone to read. I will not be able to use this template if I have to allow public access to my bucket in order to make policies for it.

@cmurphy23
Copy link
Author

Additionally, I wonder if the other bucket policies will be able to be created at all, or if the whole template only works now if the access is public. If I recall the problem correctly, these settings seem necessary to allow any bucket policies to be used at all, even if the policy is to not allow access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants