-
Notifications
You must be signed in to change notification settings - Fork 2
Migrate to mappy #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Donaim
wants to merge
18
commits into
master
Choose a base branch
from
migrate-to-mappy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Migrate to mappy #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented a test suite for validating the migration from minimap2 executable to mappy, ensuring compatibility and performance. - Added tests for basic alignment, output format, and edge cases in the minimap2 compatibility tests. - Created unit tests for SAM format conversion utilities, including CIGAR string conversion and SAM line construction. - Included tests for calculating SAM flags and generating SAM headers. - Established helper functions for converting mappy's internal format to SAM format, ensuring proper integration with the existing codebase.
…th complex sequences
…ions and ensuring backward compatibility. Update documentation and migration checklist.
…for mappy installation in migration checklist.
…lation assumptions to rely solely on mappy.
…se mappy exclusively
…ove Docker/Singularity testing steps
… verify no minimap2 dependency
…ve deprecated parameters, and complete code cleanup.
85ef043 to
c6adae3
Compare
…ted reference positions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29