fix: move change-password to ShellRoute and improve code quality#68
Merged
cevheri merged 2 commits intocevheri:mainfrom Mar 23, 2026
Merged
Conversation
Move change-password route from AuthFeatureRoutes into ShellRoute so it renders inside AppShell (sidebar/navigation) like Account screen, fixing the full-screen inconsistency when navigating from Settings. Key changes: - Split AuthFeatureRoutes into publicRoutes and authenticatedRoutes - Remove Scaffold/AppBar from ChangePasswordScreen, use custom header pattern matching AccountScreen for visual consistency - Fix _handlePopScope crash: unsafe cast of null to BuildContext when system back button triggers pop - Fix ChangePasswordChanged event missing Equatable props override - Fix submit button disable logic (was always callable during loading) - Localize hardcoded English string to ARB files (EN + TR) - Remove dead code: unused TogglePasswordVisibility event, unused state subclasses, orphaned authenticationFailKey constant - Remove duplicate "Change Password" heading inside card - Move test file to correct directory (test/features/auth/) - Expand test coverage from 72% to 97% (16 tests covering state changes, password visibility, pop scope, and navigation) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cevheri
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShellRouteso both screens behave consistently.BuildContextcast in_handlePopScope(crash on system back button), missingEquatableprops onChangePasswordChangedevent, and submit button not actually disabling during loading state.Test plan
fvm flutter test)fvm dart analyzereports no issues🤖 Generated with Claude Code