Skip to content

fix: separate account and change password cards in settings #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cevheri merged 2 commits into from
Mar 23, 2026
Merged

fix: separate account and change password cards in settings #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a4af52
fix: separate account and change password into individual cards
yusuf-gundogdu Mar 23, 2026
5f5533c
fix: enable Tab key navigation from username to password on login
yusuf-gundogdu Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/features/auth/presentation/pages/login_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class _LoginScreenState extends State<LoginScreen> with SingleTickerProviderStat
final GlobalKey<FormBuilderState> _loginFormKey = GlobalKey<FormBuilderState>(debugLabel: '__loginFormKey__');
final GlobalKey<ScaffoldState> _scaffoldKey = GlobalKey<ScaffoldState>(debugLabel: '__loginScaffoldKey__');
late AnimationController _animController;
final FocusNode _forgotPwFocus = FocusNode(skipTraversal: true);

@override
void initState() {
Expand All @@ -37,6 +38,7 @@ class _LoginScreenState extends State<LoginScreen> with SingleTickerProviderStat

@override
void dispose() {
_forgotPwFocus.dispose();
_animController.dispose();
super.dispose();
}
Expand Down Expand Up @@ -497,6 +499,7 @@ class _LoginScreenState extends State<LoginScreen> with SingleTickerProviderStat
key: loginTextFieldUsernameKey,
name: 'username',
decoration: const InputDecoration(hintText: 'm@example.com'),
textInputAction: TextInputAction.next,
validator: FormBuilderValidators.compose([
FormBuilderValidators.required(errorText: S.of(context).required_field),
FormBuilderValidators.minLength(4, errorText: S.of(context).min_length_4),
Expand Down Expand Up @@ -558,6 +561,7 @@ class _LoginScreenState extends State<LoginScreen> with SingleTickerProviderStat
Widget _forgotPasswordLink(BuildContext context) {
return TextButton(
key: loginButtonForgotPasswordKey,
focusNode: _forgotPwFocus,
onPressed: () => context.push(ApplicationRoutesConstants.forgotPassword),
style: TextButton.styleFrom(
padding: const EdgeInsets.symmetric(horizontal: 4),
Expand Down
6 changes: 6 additions & 0 deletions lib/features/settings/presentation/pages/settings_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ class SettingsScreen extends StatelessWidget {
subtitle: 'View or edit your profile information',
onTap: () => context.push(ApplicationRoutesConstants.account),
),
],
),
const SizedBox(height: AppSpacing.sm),
_SettingsSection(
title: S.of(context).change_password,
children: [
_SettingsTile(
key: settingsChangePasswordButtonKey,
icon: Icons.lock_outline,
Expand Down