Fix: the ability to use a custom button via buttonRef prop was broken.#45
Open
some1-in-here wants to merge 2 commits intocesarwbr:masterfrom
Open
Fix: the ability to use a custom button via buttonRef prop was broken.#45some1-in-here wants to merge 2 commits intocesarwbr:masterfrom
some1-in-here wants to merge 2 commits intocesarwbr:masterfrom
Conversation
some1-in-here
force-pushed
the
fix-buttonRef-prop
branch
from
43b54b5 to
3992957
Compare
|
@cesarwbr Would be nice if this pull request was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was impossible to use custom buttonRef.
Moreover, the buttonRef has been combined with the EmojiPicker component in the React.portal. And now, we have two components independent of each other.
If any changes are required, I will be happy to make them.