Refactor weapon info fetching and error handling in misc.py#66
Merged
cesaregarza merged 1 commit intomainfrom Jan 4, 2026
Merged
Refactor weapon info fetching and error handling in misc.py#66cesaregarza merged 1 commit intomainfrom
cesaregarza merged 1 commit intomainfrom
Conversation
This commit introduces a new private function to streamline the fetching of JSON data from URLs, enhancing error handling for both weapon info and language translations. It replaces direct requests with the new function, improving code readability and maintainability. Additionally, it ensures that failures in fetching translations are logged appropriately, and existing translations are merged correctly before updating Redis. Logging improvements are also made for better traceability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new private function to streamline the fetching of JSON data from URLs, enhancing error handling for both weapon info and language translations. It replaces direct requests with the new function, improving code readability and maintainability. Additionally, it ensures that failures in fetching translations are logged appropriately, and existing translations are merged correctly before updating Redis. Logging improvements are also made for better traceability.