Fix/chartadditional annotations for cli args

[jrhoward]

this contains the fix for a bug introduced in pull request #537

It is now handling the cli args correctly.

Validated by following the following document

https://cert-manager.io/docs/usage/istio-csr/installation/

using the following helm values for annotations:

app:
  certmanager:
    additionalAnnotations:
      - name: some.cert-manager.io/custom-fields
        value: |
          [{ "Name": "field1", "Value": "value1" },{ "Name": "field2", "Value": "value2" }]
      - name: another.cert-manager.io/custom-field2
        value: "a value"

[cert-manager-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jakexks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cert-manager-prow]

Hi @jrhoward. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[erikgb]

/ok-to-test

[Copilot]

Pull Request Overview

Fix chart templating for passing cert-manager additionalAnnotations via CLI flags so values with commas are handled.

• Wraps certain flag strings in extra quotes within the template
• Applies the change to both certificate-request and istiod-cert annotation flags

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Adding inner quotes via printf ""%s=%s"" and then piping to quote will produce a literal argument that starts and ends with a double-quote, e.g. ""--certificate-request-additional-annotations=..."" in argv. Kubernetes does not invoke a shell for container args, so these quotes are not stripped and become part of the flag string, which can break flag parsing. If the intent is to quote only the value to preserve commas, quote the value portion instead of the entire flag, for example:

Suggested change

	- {{ printf "\"%s=%s\"" "--certificate-request-additional-annotations" ( join "," $annotations ) | quote -}}
	- --certificate-request-additional-annotations="{{ join "," $annotations }}"

[jrhoward]

the quotes need to be passed through as it is part of the json structure passed as a command line argument to the container. Copilot is wrong in this case

[jrhoward]

the quotes need to be passed through as it is part of the json structure passed as a command line argument to the container. Copilot is wrong in this case

[Copilot]

Same double-quoting issue as above; this will pass a literal string beginning and ending with a quote to the process. Prefer quoting the value portion only, or revert if literal quotes are not required. For example:

• {{ printf "%s=%s" "--istiod-cert-additional-annotations" ( printf ""%s"" ( join "," $annotationList ) ) | quote -}}

Suggested change

	- {{ printf "\"%s=%s\"" "--istiod-cert-additional-annotations" ( join "," $annotationList ) | quote -}}
	- {{ printf "%s=%s" "--istiod-cert-additional-annotations" ( join "," $annotationList ) | quote -}}

[jrhoward]

the quotes need to be passed through as it is part of the json structure passed as a command line argument to the container. Copilot is wrong in this case

[cert-manager-prow]

@jrhoward: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cert-manager-istio-csr-istio-v1-20	bd99e0e	link	true	/test pull-cert-manager-istio-csr-istio-v1-20
pull-cert-manager-istio-csr-istio-v1-21	bd99e0e	link	true	/test pull-cert-manager-istio-csr-istio-v1-21
pull-cert-manager-istio-csr-istio-v1-22	bd99e0e	link	true	/test pull-cert-manager-istio-csr-istio-v1-22
pull-cert-manager-istio-csr-istio-ambient	bd99e0e	link	true	/test pull-cert-manager-istio-csr-istio-ambient
pull-cert-manager-istio-csr-istio-v1-23	bd99e0e	link	true	/test pull-cert-manager-istio-csr-istio-v1-23
pull-cert-manager-istio-csr-istio-v1-24	bd99e0e	link	true	/test pull-cert-manager-istio-csr-istio-v1-24
pull-cert-manager-istio-csr-istio-v1-27	bd99e0e	link	true	/test pull-cert-manager-istio-csr-istio-v1-27
pull-cert-manager-istio-csr-istio-v1-26	bd99e0e	link	true	/test pull-cert-manager-istio-csr-istio-v1-26
pull-cert-manager-istio-csr-istio-v1-28	bd99e0e	link	true	/test pull-cert-manager-istio-csr-istio-v1-28
pull-cert-manager-istio-csr-istio-v1-29	bd99e0e	link	true	/test pull-cert-manager-istio-csr-istio-v1-29

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.