Update getGlobalInfluenceM.m #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This routine is buggy in the part executed when passing more than one structure in structsV.
Proposed changes:
1) strBmletInd index should be used instead of structNum
2) computing indexS = planC{end} was missing.
3) influenceM = spalloc(numVoxels, numPBs, maxnnz), where numVoxels = prod(getUniformScanSize(planC{indexS.scan}(getStructureAssociatedScan(structsV(1))))) was missing.
BTW, this routine needs to be further debugged in the final part where the sparse influence matrix is populated.
Indeed, I observed unespected discrepancies when computing the dose of one ROI (using getSingleGlobalInfluenceM()) vs. extrapolating the very same ROI's dose from the global dose computed over more ROIs.
These are very small discrepacies, which are not expected, I double checked the correct sampling rate was used on both tests.
Please debug and fix the cause. I am still investigating the cause.
P.S. could you accept my invitation to join the CERR google group (my email: alfonsoisola@gmail.com).
Regards, Alfonso
Regards.
Fixed a typo in the committed change. Sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This routine is buggy in the part executed when passing more than one structure in structsV.
Proposed changes:
BTW, this routine needs to be further debugged in the final part where the sparse influence matrix is populated (lines 86-117). Indeed, I observed unexpected discrepancies when computing the dose of "only one" ROI (i.e., using getSingleGlobalInfluenceM()) vs. extrapolating the very same ROI's dose from the global dose computed over more multiple ROIs.
These are very small discrepacies, which are not expected, I double checked the correct sampling rate was used on both tests.
Please debug and fix the cause. I am still investigating the cause.
P.S. could you accept my invitation to join the CERR google group (my email: alfonsoisola@gmail.com)?.
Regards, Alfonso
Regards.