Revert "Fix/validate filter params"

sourcecode/hub/app/Http/Requests/ContentFilter.php

@@ -16,20 +16,20 @@
 use Laravel\Scout\Builder;
 use Override;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
+
 use function abort;
 use function trans;
 
 class ContentFilter extends FormRequest
 {
-    /** @var Builder<Content> */
+    /** @var Builder<Content>  */
     private Builder $builder;
     private bool $forUser = false;
     private bool $languageChanged = false;
     private bool $queryChanged = false;
     private bool $typesChanged = false;
 
-    #[Override]
-    protected function failedValidation(Validator $validator): never
+    #[Override] protected function failedValidation(Validator $validator): never
     {
         abort(404);
     }
@@ -42,9 +42,8 @@ public function rules(): array
         return [
             'q' => ['sometimes', 'string', 'max:300'],
             'language' => ['sometimes', 'string', 'max:100'],
-            'sort' => ['sometimes', 'required', Rule::in('created', 'updated', 'views')],
+            'sort' => ['sometimes', Rule::in('created', 'updated', 'views')],
             'type' => ['sometimes', 'array'],
-            'type.*' => ['string', 'max:255', 'regex:/^[a-zA-Z0-9._+ ]+$/'],
         ];
     }
 
@@ -90,13 +89,15 @@ public function getLanguageOptions(bool $withExpectedHits = false): array
 
         return $options
             ->map(
-                fn(int $value, string $key) => $key === ''
-                    ? trans('messages.filter-language-all')
-                    : (locale_get_display_name($key, $displayLocale) ?: (locale_get_display_name($key, $fallBack) ?: $key)),
+                fn(int $value, string $key) =>
+                $key === ''
+                ? trans('messages.filter-language-all')
+                : (locale_get_display_name($key, $displayLocale) ?: (locale_get_display_name($key, $fallBack) ?: $key)),
             )
             ->when(
                 $withExpectedHits,
-                fn(Collection $items) => $items->map(fn(string $value, string $key) => sprintf('%s (%d)', $value, $options[$key] ?? 0)),
+                fn(Collection $items) =>
+                $items->map(fn(string $value, string $key) => sprintf('%s (%d)', $value, $options[$key] ?? 0)),
             )
             ->sort()
             ->toArray();
@@ -216,7 +217,8 @@ public function applyCriteria(Builder $query): Builder
                 count($this->getContentTypes()) > 0,
                 fn(Builder $query) => $query
                     ->whereIn('content_type', $this->getContentTypes()),
-            );
+            )
+        ;
 
         $this->builder = clone($query);
 
@@ -304,6 +306,8 @@ public function getWithModel(Builder $builder, int $limit, bool $forUser = false
      */
     private function attachModel(array $hits, bool $forUser, bool $showDrafts): Collection
     {
+        $hits = new Collection($hits);
+
         $eagerLoad = ['users'];
         if ($showDrafts) {
             $eagerLoad[] = 'latestVersion';
@@ -312,14 +316,12 @@ private function attachModel(array $hits, bool $forUser, bool $showDrafts): Coll
             $eagerLoad[] = 'latestPublishedVersion';
         }
 
-        /** @phpstan-ignore-next-line */
         $contents = Content::whereIn('id', $hits->pluck('id'))
             ->with($eagerLoad)
             ->withCount(['views'])
             ->get()
             ->keyBy('id');
 
-        /** @phpstan-ignore-next-line */
         return $hits
             ->map(fn(array $item) => [
                 ...$item,