[T99687] BREAKING CHANGE(dayjs): Migrate moment to dayjs

[edwin-tandiono]

Compared to moment, dayjs is significantly smaller (73.1 kB vs 3 kB minified & gzipped) while still having similar date APIs. This should help reduce client bundle size for our front end projects which use cermati utils.

This change introduces a breaking behavior regarding invalid date input format.
Previously, parsing an incomplete input date using moment will fill the missing value. dayjs doesn't have this behavior. Considering adding date-format validation if your input is not guaranteed to have a valid format.

const dateWithoutSeconds = '2024-05-07T13:00';
const dateFormatExpectingSeconds = 'YYYY-MM-DDTHH:mm:ss';

moment(dateWithoutSeconds, dateFormatExpectingSeconds).format()
> '2024-05-07T13:00:00+07:00'

dayjs(dateWithoutSeconds, dateFormatExpectingSeconds).format()
> 'Invalid Date'

[ray1412]

lgtm

[nsofian]

Compared to moment, dayjs is significantly smaller (73.1 kB vs 3 kB minified & gzipped) while still having similar date APIs. This should help reduce client bundle size for our front end projects which use cermati utils.

This change introduces a breaking behavior regarding invalid date input format. Previously, parsing an incomplete input date using moment will fill the missing value. dayjs doesn't have this behavior. Considering adding date-format validation if your input is not guaranteed to have a valid format.

const dateWithoutSeconds = '2024-05-07T13:00';
const dateFormatExpectingSeconds = 'YYYY-MM-DDTHH:mm:ss';

moment(dateWithoutSeconds, dateFormatExpectingSeconds).format()
> '2024-05-07T13:00:00+07:00'

dayjs(dateWithoutSeconds, dateFormatExpectingSeconds).format()
> 'Invalid Date'

I tried it still successfully parsed the string (?)

> const dateWithoutSeconds = '2024-05-07T13:00';
undefined
> const dateFormatExpectingSeconds = 'YYYY-MM-DDTHH:mm:ss';
undefined
> const dayjs = require('dayjs')
undefined
> dayjs(dateWithoutSeconds, dateFormatExpectingSeconds).format()
'2024-05-07T13:00:00+07:00'

using the same dayjs version, 1.11.10

[edwin-tandiono]

I tried it still successfully parsed the string (?)

Sorry, forgot to mention that the issue occurs if we extend custom parse format (which we do) which is necessary to handle custom formats provided by the users.

const dayjs = require('dayjs');
const customParseFormat = require('dayjs/plugin/customParseFormat');

dayjs.extend(customParseFormat);

const dateWithoutSeconds = '2024-05-07T13:00';
const dateFormatExpectingSeconds = 'YYYY-MM-DDTHH:mm:ss';

console.log(dayjs(dateWithoutSeconds, dateFormatExpectingSeconds).format());

> Invalid Date

will add these details on the changelog

[nsofian]

lgtm from me

[edwin-tandiono]

This PR is pending due to known dayjs strict parsing bug iamkun/dayjs#929.

> dayjs('2024-05-20T00:00:00.000+07:00', 'YYYY-MM-DD[T]HH:mm:ss.SSSZ', true).isValid()
true

> dayjs('2024-05-20T00:00:00.000Z', 'YYYY-MM-DD[T]HH:mm:ss.SSSZ', true).isValid()
false

The PR is currently nor urgent as our front end projects don't have date time validator for now. We will revisit this PR once the need arises, and we'll see if there are fix or workaround by then.