Skip to content

Conversation

@qyul
Copy link

@qyul qyul commented May 21, 2017

Hey there.
I made some small fixes.

  • Disallow non-printed characters to influence the HP bar (hehehe)
  • fix for incorrect variable name leading to timer bug
  • Minor UI cursor adjustments
  • changed word count select to html5 placeholder

Hope you don't mind if I play around with my own branch. I plan on keeping it local, unless you don't mind me hosting it somewhere with credit.

Thanks for making something like this :)
-qsmk

qyuli/s#7377 added 3 commits May 21, 2017 23:14
* Disallow non-printed characters to influence the HP bar (hehehe)
* fix for incorrect variable name leading to timer bug
* Minor UI cursor adjustments
* changed word count select to html5 placeholder
@cerey
Copy link
Owner

cerey commented May 21, 2017

Hey,

I don't mind at all! Actually looking back some of the code is reaaaaaally bad and I commend you for being brave enough to trek through this mess. I'll probably go through and rewrite chunks of it myself when I'm free.

That said, I'd prefer if you didn't host it publicly. I'm considering moving it off GitHub so you can see how that would be a problem... Thanks for understanding.

Cheers, and you're welcome :)
cerey

@qyul
Copy link
Author

qyul commented May 21, 2017

Ahahaha, the code could be worse.

That said, I'd prefer if you didn't host it publicly. I'm considering moving it off GitHub so you can see how that would be a problem... Thanks for understanding.

Sure. No worries.

Would you be interested in help with development? I was mostly wanting to clean things up and maybe add new features.

@cerey
Copy link
Owner

cerey commented May 22, 2017

It's wonderful of you to offer, but I'll have to pass. This is a pretty personal project so everything (including the eventual pain of cleaning the code) is on me.

That said, thanks for finding the silly pause/paused issue. I remember trying to fix that back in the day, being really frustrated that nothing was working, and just moving on... The joy of debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants