Skip to content

can change settings of the request #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Velinsky wants to merge 1 commit into
base: master
Choose a base branch
from
Open

can change settings of the request #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/wundergroundnode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ var Wunderground = function(apikey) {
"use strict";

var that = this;
var format = ".json";

that.chainedRequests = [];
var format = ".json";
that.requestSettings = null;

that.conditions = function() {
this.chainedRequests.push("conditions/");
Expand Down Expand Up @@ -68,6 +69,11 @@ var Wunderground = function(apikey) {
return this;
};

that.settings = function(settings) {
this.requestSettings = settings;
return this;
};

/**
* Historical request, cannot be chained.
*
Expand Down Expand Up @@ -130,7 +136,9 @@ var Wunderground = function(apikey) {
}

// Construct the url
var url = 'http://api.wunderground.com/api/' + apikey + '/' + that.chainedRequests.join('') + 'q/'+query + format;
var settings = that.requestSettings ? that.requestSettings + '/' : '';
var url = 'http://api.wunderground.com/api/' + apikey + '/' + that.chainedRequests.join('') + settings + 'q/'+query + format;

that.chainedRequests = [];

// Request the url
Expand Down
16 changes: 16 additions & 0 deletions test/testWundergroundnode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,22 @@ describe('Testing Weather Underground Node Client:', function(){

});


it('Adding settings to the request.', function(done){
getDevKey(function(key){
var wunderground = new Wunderground(key);
// test only that the request still works, lib does not provide way of cheking the sent url now
wunderground.hourlyForecast().hourlyTenDayForecast().forecast().almanac().yesterday().settings('lang:CZ').request('84111', function(err, response){
response.should.have.property('almanac');
response.should.have.property('hourly_forecast');
response.should.have.property('forecast');
response.should.have.property('history');
done();
});
});

});

it('Call without a resource', function(done){

getDevKey(function(key){
Expand Down