Skip to content
This repository was archived by the owner on Mar 8, 2021. It is now read-only.

Depend on crypto-password, and add support for PBKDF2 #137

Closed
zonotope wants to merge 23 commits into from
Closed

Depend on crypto-password, and add support for PBKDF2 #137

zonotope wants to merge 23 commits into from

Conversation

@zonotope
Copy link

@zonotope zonotope commented Mar 10, 2015

Fixes #110

zonotope added 23 commits March 8, 2015 23:05
@zonotope
add crypto-password dep, and remove jbcrypt.
d9cd5a3
@zonotope
formatting.
9881fb2
@zonotope
use crypto.password.bcrypt functions.
20edd3d
@zonotope
hof to return a credential function when given a verifier. refactored
4a5119f 
from bcrypt-credential-fn.
@zonotope
add pbkdf2
870be7f
@zonotope
formatting
8b531cc
@zonotope
add bcrypt suffixes to tests.
e1184bd
@zonotope
test pbkdf2 credential fn.
3b83a6b
@zonotope
Revert "formatting"
96412b0 
This reverts commit 8b531cc.
@zonotope
Revert "formatting."
73169d7 
This reverts commit 9881fb2.
@zonotope
add docstring to build-credential-fn
fd45f45
@zonotope
more precise.
00c52f0
@zonotope
throw in scrypt
665f8e8
@zonotope
even more clarity.
f4a415c
@zonotope
this should be hidden.
eb6fa82
@zonotope
simple scrypt test.
833940e
@zonotope
comment hash-pbkdf2
2f601b8
@zonotope
comment pbkdf2-verify, and clarify comment for bcrypt-verify
cb08e3e
@zonotope
fix typo.
941a560
@zonotope
docstring for pbkdf2-credential-fn
5a57918
@zonotope
docstring for hash-scrypt
0b26114
@zonotope
docstring for scrypt-verify.
7b1d64a
@zonotope
docstring for scrypt-credential-fn.
0a3641b
@cemerick
Copy link
Owner

cemerick commented Mar 13, 2015

This looks really great on a quick skim. Could you do a couple things before I really dig in and then merge this though?

  1. Please squash your commits down to a really small number (probably one?)
  2. There are some areas that pop on the diff only because of formatting changes. Could you revert those lines? I don't care that much about formatting, I just want blame to be as useful as possible.

Thanks so much for working on this. Looking forward to merging! :-D

@zonotope
Copy link
Author

zonotope commented Mar 13, 2015

@cemerick it was easier just to do it all in a different branch. #139 is the new pr.

@zonotope zonotope closed this Mar 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for PBKDF2

2 participants

@zonotope @cemerick