This repository was archived by the owner on Dec 7, 2018. It is now read-only.
Open
Conversation
This adds initial websocket support. It is not complete yet as while you can create a websocket and send data via the websocket, receiving data from the websocket does not work, for reasons I've yet to determine. This changes the API for route_request, because Reel::Request#connection is not defined. It includes the request object in a 'reel.request' entry in the env, so that rack apps can do: ws = env['reel.request'].websocket if env['reel.request'].websocket?
Member
|
For Rack applications, it might make more sense to use something more Rack-centric, like: |
Author
|
I'm building a websocket plugin for the web framework I work on (Roda), and I added support for faye-websocket-ruby first. I'd like to additionally support websockets via Reel/Celluloid, so that people that don't want to use eventmachine have a choice. |
|
@jeremyevans Did you have a chance to dig into it? I assumed reel supports websockets natively without having to use Event Machine. That's what Celluloid is for actually... |
Author
|
@Nowaker reel supports websockets, but reel-rack does not. I haven't done more work on this, and don't have plans to do so in the foreseeable future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds initial websocket support. It is not complete yet as while
you can create a websocket and send data via the websocket, receiving
data from the websocket does not work, for reasons I've yet to
determine.
This changes the API for route_request, because Reel::Request#connection
is not defined. It includes the request object in a 'reel.request' entry
in the env, so that rack apps can do:
ws = env['reel.request'].websocket if env['reel.request'].websocket?
If anyone could provide a pointer to why receiving data via the websocket
may not be working, that would be helpful.