This repository was archived by the owner on Dec 7, 2018. It is now read-only.
construct full url to pass to MockRequest#env_for#15
Open
challengee wants to merge 1 commit intocelluloid:masterfrom
Open
construct full url to pass to MockRequest#env_for#15challengee wants to merge 1 commit intocelluloid:masterfrom
challengee wants to merge 1 commit intocelluloid:masterfrom
Conversation
Member
|
It's probably fine you're not handling the scheme, as reel-rack presently doesn't provide HTTPS support. It should! But that doesn't block this patch. What happens if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came accross issue #5 while testing reel with rack urlmap. It's not working because
SERVER_NAMEandSERVER_PORTdo not get set correctly (see https://github.com/rack/rack/blob/master/lib/rack/mock.rb#L88).I modified this so that a more complete url is passed to
env_for. I don't know if it's the right way to go.Reel::Request#urlshould return a full url?What do you think?