blob CLI: prevent panic when using --input-file without positional args#4819
Open
Sushil-19 wants to merge 1 commit intocelestiaorg:mainfrom
Open
blob CLI: prevent panic when using --input-file without positional args#4819Sushil-19 wants to merge 1 commit intocelestiaorg:mainfrom
Sushil-19 wants to merge 1 commit intocelestiaorg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4625
This PR fixes a runtime panic in the
celestia blob submitCLI command when--input-fileis used without positional arguments.Previously,
PreRunEaccessedargs[0]andargs[1]unconditionally, which caused:panic: runtime error: index out of range [0] with length 0
when the command was executed as:
celestia blob submit --input-file input.json
The fix skips positional argument processing when
--input-fileis provided and validates arguments only when necessary.This prevents the panic and ensures the CLI returns proper validation errors instead.