ci: separate fast unit tests from coverage collection#4814
Open
walldiss wants to merge 1 commit intocelestiaorg:mainfrom
Open
ci: separate fast unit tests from coverage collection#4814walldiss wants to merge 1 commit intocelestiaorg:mainfrom
walldiss wants to merge 1 commit intocelestiaorg:mainfrom
Conversation
Add test-unit-fast Makefile target (no coverage flags) and run it on the blocking matrix job (ubuntu + macOS). Move coverage collection to a standalone ubuntu-only job that runs in parallel and doesn't gate integration tests. Reduces the blocking test time by ~25% on both platforms and eliminates redundant macOS coverage uploads to codecov.
walldiss
requested review from
Wondertan,
mcrakhman,
renaynay and
vgonkivs
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4814 +/- ##
==========================================
- Coverage 44.83% 35.72% -9.11%
==========================================
Files 265 311 +46
Lines 14620 21442 +6822
==========================================
+ Hits 6555 7661 +1106
- Misses 7313 12787 +5474
- Partials 752 994 +242 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-unit-fastMakefile target: same astest-unitbut without-covermode=atomic -coverprofile=coverage.txttest-unit-fast— this is the blocking gate for integration testscoveragejob that runs in parallel and doesn't gate integration testsWhy this helps
-covermode=atomicinstruments every memory access and adds ~25% overhead to the test run. Since macOS coverage is redundant (codecov uses Linux numbers), running full coverage on both platforms was pure waste. The fast test job still catches all failures on both platforms; coverage is collected once on Linux.