ci: remove setup job and fix debug flag propagation#4813
Open
walldiss wants to merge 1 commit intocelestiaorg:mainfrom
Open
ci: remove setup job and fix debug flag propagation#4813walldiss wants to merge 1 commit intocelestiaorg:mainfrom
walldiss wants to merge 1 commit intocelestiaorg:mainfrom
Conversation
The setup job was broken: it wrote to $GITHUB_ENV instead of $GITHUB_OUTPUT, so the debug flag never reached other jobs. It also compared runner.debug to "true" when the actual value is "1". Remove the job entirely and evaluate runner.debug inline in each step that needs it, removing ~30s of startup latency from all downstream jobs.
walldiss
requested review from
Wondertan,
mcrakhman,
renaynay and
vgonkivs
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setupjob fromgo-ci.ymlneeds: [setup]from all downstream jobs, allowing them to start immediately when triggered${{ needs.setup.outputs.debug }}expression with${{ runner.debug == '1' && 'true' || 'false' }}evaluated inline in each stepBug fixed
The
setupjob had two bugs that made it a no-op:$GITHUB_ENVinstead of$GITHUB_OUTPUT, sosteps.debug.outputs.debugwas always emptyrunner.debugis'1'when enabled, not'true', so the condition== "true"never matchedThe debug flag was silently doing nothing. This PR fixes it while also removing the job startup overhead (~30s saved from all downstream jobs no longer waiting on
setup).