fix compatibility with IDEA 2016.1

[ulitink]

Hi Chris!
I'm from WebStorm team. Are you planning to support your plugin? We have some questions from users about it.

[cefolger]

Thanks ulitink! Were you able to run the unit tests against this? Sorry I haven't looked at this in awhile, I'll run and pull this in over the weekend.

[ulitink]

No, I haven't run tests, just fixed compilation. But my changes don't bring new behavior, so tests should be ok. Thanks for the great plugin!

[sergiogarciadev]

I'm a new to Plugins Development, but I tried this Pull Request with WebStorm 2016.1.3 and it's works pretty well.

There are currently 2 failing tests, probably due problems on MockFunction

java.lang.ArrayIndexOutOfBoundsException: 0

    at com.chrisfolger.needsmoredojo.core.amd.define.NearestAMDImportLocator.getIndexOfParameter(NearestAMDImportLocator.java:123)
    at com.chrisfolger.needsmoredojo.core.amd.define.NearestAMDImportLocator.getDefineLiteral(NearestAMDImportLocator.java:97)
    at com.chrisfolger.needsmoredojo.core.amd.define.TestNearestAMDImportLocator.testDefineLiteralIsRetrievedWhenCursorIsOverParameter(TestNearestAMDImportLocator.java:113)


java.lang.ArrayIndexOutOfBoundsException: 0

    at com.chrisfolger.needsmoredojo.core.amd.define.NearestAMDImportLocator.getParameter(NearestAMDImportLocator.java:60)
    at com.chrisfolger.needsmoredojo.core.amd.define.TestNearestAMDImportLocator.testParameterIsRetrievedWhenCursorIsOverDefineLiteral(TestNearestAMDImportLocator.java:131)

[simplicitytrade]

@cefolger @ulitink @Sergio-Garcia Could you provide an (installable) JAR file of "needsmoredojo 0.71" for WebStorm/PHPStorm? My attempt unfortunately failed.

[sergiogarciadev]

@simplicitytrade sure, please download from this link.
https://www.dropbox.com/s/4xarjv0c3o4sr9y/needsmoredojo-0.7.1.jar?dl=0

[SergKam]

@Sergio-Garcia
I've tried this jar(from dropbox). It doesn't work for me. It shows errors in WebStorm
NoSuchMethodError: Worker exited due to exception: com.intellij.lang.javascript.psi.JSFunctionExpression.getParameters()[Lcom/intellij/lang/javascript/psi/JSParameterItemWithSource;

WebStorm 2016.2 EAP
Build #WS-162.1024.2, built on June 21, 2016
JRE: 1.8.0_76-release-b216 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o

[sergiogarciadev]

Hi, I'm using WebStorm 2016.1.3, the lastest stable version.

Maybe on 2016.2 there are new API changes, @ulitink is it the case?

[ulitink]

Hi. I haven't encountered new API changes which affect the plugin, but I somehow missed one place to fix. Please check this jar.

[SergKam]

@ulitink Thank you! It's finally working again!

[mattdoe]

@ulitink Thank you! That works for me on version 2016.2.1.

@cefolger Will this be incorporated into an update of the plugin?

[wanghanbo]

Could give me another url for new jar?

[sindilevich]

@cefolger, @ulitink, @LawfulHacker, is it possible you republish the fixed plugin? When the fixed version 0.7.1 is going to be publicly available through the JetBrains Plugin Repository?

Thank you in advance!

[sktguha]

where can i get the latest working jar file for webstorm 2016.3.3 ? i installed the latest plugin from the repository but none of the functionality is working

[sktguha]

the dropbox links are not working. could anyone be kind to reupload the working jar file again ?
@mattdoe @ulitink @SergKam

[sindilevich]

@sktguha, I can upload it to a publicly available storage, if you have one.

[sktguha]

err didn't get u . can u upload it to a google drive ? or here itself ?

[sindilevich]

@sktguha, try this one.

[sktguha]

thanks. it is working now. I must say it is a great plugin and tons of feautures. thanks @cefolger for making this. will try to contribute if possible in future :)

[sktguha]

would be helpful to update the main page with link to this updated jar file to help people with latest webstorm