Publish an RFC book #91
Merged
+70
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Palacios <accorell@amazon.com>
Signed-off-by: Adrian Palacios <accorell@amazon.com>
Signed-off-by: Adrian Palacios <accorell@amazon.com>
adpaco-aws
requested review from
cdisselkoen,
emina,
john-h-kastner-aws and
shaobo-he-aws
mwhicks1
approved these changes
Dec 3, 2024
Contributor
mwhicks1
left a comment
mwhicks1
left a comment
There was a problem hiding this comment.
This looks great! But: Should RFC 68 be dropped? It was superseded by RFC 82. Should probably "un-accept" it in this repository along with changing the mdBook to not include it.
Signed-off-by: Adrian Palacios <accorell@amazon.com>
Contributor
Author
|
Good point, I've changed the I don't think we've actually defined what the process to "un-accept" an RFC is, but we have at least two options:
|
Contributor
I like the idea of doing this. It was accepted, and has useful context/discussion compared to the 82. |
Signed-off-by: Adrian Palacios <accorell@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish an RFC book using
mdBook. Hopefully, an RFC book will make it easier for Cedar contributors and others to access the most up-to-date version of accepted RFCs, summaries of RFC statuses, and also act as an alternative to GitHub's Markdown rendering.The changes in this PR are mainly:
mdBookto work as smoothly as possible.I've tested these changes in my own fork, and the results can be accessed here: https://adpaco-aws.github.io/rfcs/
Rendered