Fixing another bug with ids #674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Eline <aeline@amazon.com>
cdisselkoen
approved these changes
Feb 28, 2024
Signed-off-by: Aaron Eline <aeline+github@amazon.com>
aaronjeline
force-pushed
the
schema-ids-bugfix2
branch
from
e381e0b to
f385903
Compare
shaobo-he-aws
approved these changes
Feb 28, 2024
khieta
approved these changes
Feb 28, 2024
Comment on lines
17
to
18
| #[error("Invalid escape codes")] | ||
| StringEscape(NonEmpty<UnescapeError>), |
Contributor
There was a problem hiding this comment.
Not introduced by this PR, but it seems like it would be useful to print the UnescapeError content.
Contributor
Author
|
Closed at my git history got messed up, resubmitting in a second |
khieta
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Using reserved keywords as ids could cause the parser to panic instead of failing gracefully
Issue #, if available
N/A
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy.I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.