Fix TUN/TAP detection on CentOS 7 (#include <sys/socket.h>) (fixes #153). #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bix#153). Previously, "checking whether TUN/TAP is supported..." in "configure" failed to detect TUN/TAP support due to compile errors due to "struct sockaddr" not being defined. This fix causes sys/socket.h to be #included if it exists.
rakslice
pushed a commit
to rakslice/macemu
that referenced
this pull request
Oct 16, 2020
Fix TUN/TAP detection on CentOS 7 (#include <sys/socket.h>) (fixes cebix#153).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, "checking whether TUN/TAP is supported..." in "configure"
failed to detect TUN/TAP support due to compile errors due to "struct
sockaddr" not being defined. This fix causes sys/socket.h to be
#included if it exists.
As noted in #153 (comment): "Pull Request #64 includes a fix for this issue in BasiliskII/src/Unix/configure.ac amongst other changes." However, that PR doesn't include the #ifdef that I've included here. I'm assuming it's preferable to use the #ifdef; it certainly works for me anyway.