feat: astro-font - optimize fonts & prevent CLS#14
Open
rishi-raj-jain wants to merge 1 commit intocdvillard:mainfrom
Open
feat: astro-font - optimize fonts & prevent CLS#14rishi-raj-jain wants to merge 1 commit intocdvillard:mainfrom
rishi-raj-jain wants to merge 1 commit intocdvillard:mainfrom
Conversation
❌ Deploy Preview for sleepy-neumann-d739b6 failed.
|
❌ Deploy Preview for charlesvillard failed.
|
Owner
|
Hi Rishi. Thanks for the PR, though for some reason, the builds are failing. I'll take a look at this later. |
Author
|
No worries, I'm also exploring this and checking the logs. |
Author
|
This seems to be something arbitrary. In dev mode it says that there's an unexpected literal string, while during build it totally gives another reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Astro Font: https://www.launchfa.st/blog/building-astro-font
Changes
This PR integrates
astro-fontwhich automatically generates the fallback font and pass it as CSS variables.