Refactor/worksearch dry #242
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update deploy script to check git status is clean on all hosts before continuing. * https://internetarchive.slack.com/archives/GM13CHXBP/p1661975769694889
- Adds merge requests to the patron anonymization confirmation dialog
Change input class from large to larger to reflect the "Search Books" page. Now has the same button format.
Make "Authors" tab search button have the same format as the "Books" tab search button.
- Fix footer html rendering on covers pages unnecessarily
And probably other devices, because it didn't allow "autoplaying" the video element containing the camera stream
cdrini
force-pushed
the
refactor/worksearch-DRY
branch
from
43a7ba9 to
5188dfc
Compare
cdrini
force-pushed
the
feature/display-active-search-edition
branch
from
69672c9 to
2412411
Compare
Refactor ISBN checksum validation
…-reviewers Filter merge requests by reviewer
…status-to-are_servers_in_sync.sh Add pre_deploy.sh to check git status on all deployment servers
…rnetarchive#7018) * closes internetarchive#7016 add indices to multi-pkey db schema
…he sitewide nav also
…profile-and-settings-from-mybooks-nav removing profile and settings links from My Books nav because they are in the sitewide nav also
…redirects-bulk-script adding bulk redirect fix script
…lytics (internetarchive#7023) * Specify dropdown link type for tracker
…election-for-selectable-items fix text selection for selectable items
DRY it up with other methods
Only used there
cdrini
force-pushed
the
refactor/worksearch-DRY
branch
from
e2fe63c to
c427a72
Compare
cdrini
force-pushed
the
refactor/worksearch-DRY
branch
from
a8a2274 to
0b0aa61
Compare
Unclear why these are causing parse errors; they should be fine in lucene queries
cdrini
force-pushed
the
refactor/worksearch-DRY
branch
from
6eb07b9 to
a99656e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Technical
Testing
Screenshot
Stakeholders