fix(import)!: always generate classes with version suffixes#2728
Draft
shinebayar-g wants to merge 2 commits intocdk8s-team:2.xfrom
Draft
fix(import)!: always generate classes with version suffixes#2728shinebayar-g wants to merge 2 commits intocdk8s-team:2.xfrom
shinebayar-g wants to merge 2 commits intocdk8s-team:2.xfrom
Conversation
shinebayar-g
force-pushed
the
fix-crd-versioning
branch
from
5c3f8b9 to
ec7a4d2
Compare
…m/cdk8s#1962 Signed-off-by: Shinebayar Gansukh <3091558+shinebayar-g@users.noreply.github.com>
shinebayar-g
force-pushed
the
fix-crd-versioning
branch
from
ec7a4d2 to
a5cb339
Compare
iliapolo
changed the title
Member
|
@shinebayar-g As this is a breaking change, we won't be able to merge it without releasing a new major version. Converting to draft until then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes cdk8s-team/cdk8s#1962
Tried to tackle cdk8s-team/cdk8s#1962, turns out this is the only required change? Tested it on the following CRDs. Results seems correct.
Unfortunately it'll be a breaking change.. 😞