Skip to content

[PLUGIN-1848] File error message update #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psainics merged 1 commit into from
Jan 24, 2025
Merged

[PLUGIN-1848] File error message update #1915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions core-plugins/src/main/java/io/cdap/plugin/batch/sink/FileSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,8 @@ private Map<String, String> getFSProperties() {
try {
return GSON.fromJson(fileSystemProperties, MAP_TYPE);
} catch (JsonSyntaxException e) {
String errorMessage = String.format(
"Failed to parse filesystem properties %s with message: %s: %s", fileSystemProperties,
e.getClass().getName(), e.getMessage());
String errorMessage = String.format("Failed to parse filesystem properties %s, %s: %s",
fileSystemProperties, e.getClass().getName(), e.getMessage());
throw ErrorUtils.getProgramFailureException(
new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), errorMessage, errorMessage,
ErrorType.USER, false, e);
Expand Down
4 changes: 3 additions & 1 deletion core-plugins/src/main/java/io/cdap/plugin/batch/source/FileSourceConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,9 @@ Map<String, String> getFileSystemProperties() {
try {
return GSON.fromJson(fileSystemProperties, MAP_STRING_STRING_TYPE);
} catch (Exception e) {
throw new IllegalArgumentException(String.format("Unable to parse filesystem properties: %s", e.getMessage()), e);
throw new IllegalArgumentException(
String.format("Unable to parse filesystem properties, %s: %s", e.getClass().getName(),
e.getMessage()), e);
}
}

Expand Down
Loading