Skip to content

Conversation

@avl42
Copy link

@avl42 avl42 commented Oct 29, 2024

This PR adds the following:

"etc--udev--rules.d--24-TEMPer.rules"
This file can be copied to /etc/udev/rules.d/24-TEMPer.rules, then any of the
supported thermometers will have their device-entries (hidraw* or tty*)
be read- and writeable by all users of group "plugdev" - allowing to use
temper.py without sudo.

In temper.py there is one change in a regular expression.
A couple lines down from that there was a "recent" change in
a similar regular expression, and it makes sense for me, that
the two regular expressions should be structurally equal.
But then again, I do not own one of these devices, so I cannot
test them myself.
The removed semicolons ";" are purely cosmetic, and so is
the one change in a function's comment.

Take it, leave it, or cherrypick it... :-)

@avl42
Copy link
Author

avl42 commented Jan 31, 2025

that's strange... github adds a warning about a conflict. But this conflict seems bizarre.

This is what I thought it SHOULD look like:

    info['firmware'] = firmware
    m = re.search(r'Temp-Inner:([0-9.]*).*?, ?([0-9.]*)', reply)
    if m is not None:
      info['internal temperature'] = float(m.group(1))
      info['internal humidity'] = float(m.group(2))
    m = re.search(r'Temp-Outer:([0-9.]*).*?, ?([0-9.]*)', reply)
    if m is not None:

This so-called conflict appears to have multiple instances of the "Temp-Outer" re.search-line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants