v8.1.13: P1-3 DoLoginAsync — eliminate ThreadPool starvation#7
Merged
cct08311github merged 1 commit intodotnet8from Mar 3, 2026
Merged
v8.1.13: P1-3 DoLoginAsync — eliminate ThreadPool starvation#7cct08311github merged 1 commit intodotnet8from
cct08311github merged 1 commit intodotnet8from
Conversation
…y login Fixes #5 - Add DoLoginAsync with full async/await implementation (6 former .Result/.Wait() calls) - DC.SaveChanges() → SaveChangesAsync() for MD5 auto-rehash path - Mark DoLogin [Obsolete], keep as GetAwaiter().GetResult() wrapper for backward compat - Update all 5 demo AccountControllers + LoginController to await DoLoginAsync Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DoLoginAsynctoWTMContext— fully async implementation replacing 6.Result/.Wait()blocking calls on every authentication request.DoLoginas[Obsolete], kept as aGetAwaiter().GetResult()backward-compat wrapper.DC.SaveChanges()→DC.SaveChangesAsync()in the PBKDF2 auto-rehash path.AccountController+LoginControllercallers toawait DoLoginAsync(...).Test plan
Closes #5
🤖 Generated with Claude Code