fix: CI green — BatchSaveData signatures, ci.slnf, global.json, sync progress test#663
Merged
cct08311github merged 1 commit intodotnet8from Mar 20, 2026
Merged
Conversation
Problems fixed: 1. NETSDK1082 — BlazorDemo.Client (browser-wasm) fails to build when SDK is pinned to 8.0.x via global.json, because the wasm-tools workload installs 8.0.x-band packs that conflict with the cross-band .NET 10 manifest fallback. Solution: introduce ci.slnf (solution filter) that excludes all BlazorDemo projects from the CI build/test. The Blazor WASM client is a demo, not framework code; it does not affect test coverage. Remove the now-redundant 'Install Blazor WASM workload' step. 2. security-scan restore — dotnet list package requires restored assets. Add a restore step before the vulnerability scan. 3. Flaky progress test — Progress<T> without a SynchronizationContext posts callbacks to the thread pool, so ordering is non-deterministic. Add file-scoped SyncProgress<T> that calls the handler inline; replace all Progress<T> usages in ImportProgressTests. global.json pins SDK to 8.0.x (latestFeature rollForward) to prevent the GitHub Actions runner's preinstalled .NET 10 from being selected. https://claude.ai/code/session_017r2EfWhoDdvECdoncQg6xM
cct08311github
force-pushed
the
claude/merge-to-dotnet8-XuCiJ
branch
from
aa0fc2c to
c2df2f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all CI failures introduced by PR #659 (the big feature merge):
BatchSaveData(IProgress<ImportProgress>?)override signatures in 5 demoFrameworkUserImportVMfiles to match the new base class signature from enhancement(import): progress reporting for large Excel imports (SSE/SignalR) #607global.json(pins SDK 8.0.x) andci.slnf(solution filter excluding BlazorDemo + BlazorDemo.Client) so the Blazor WASM workload issue does not block CI buildsWalkingTec.Mvvm.slnfordotnet list package --vulnerable(.slnfnot supported by that command); add missing restore stepProgress<T>with a synchronousSyncProgress<T>inImportProgressTeststo avoid non-deterministic thread-pool callback orderingTest plan
build-and-test✅js-test✅release-tooling-test✅security-scan✅https://claude.ai/code/session_017r2EfWhoDdvECdoncQg6xM