Conversation
5dffc7f to
0826473
Compare
|
I like this idea, particularly since we so often want a GeoServer running, and you've decoupled the configuration of GeoServer from cloud-local. The only thing I wonder about is whether we can NOHUP the GeoServer start-up so that it runs in the background. If we could, can we make the "stop" command kill the GeoServer process, too? That might make things slightly cleaner for people, rather than tying up their terminal session. (Okay, yes: They could simply choose to NOHUP their cloud-local invocation, but let's make it easier on folks, eh?) |
|
[picky, picky, picky] I think your commit message meant, "invoked" rather than "envoked". I'll admit, I get "invoke" and "evoke" confused more often than most people, but we might want to tidy this up. |
* Added a command line parameter that is only read when cloud-local start is envoked. If the parameter -gs is provided and GEOSERVER_HOME is set then the script will start and stop GeoServer with the cloud. Note GeoServer runs in the current thread so ctrl+c is needed to shut it down. * Added documentation of -gs command. Signed-off-by: Austin Heyne <aheyne@ccri.com>
1602a48 to
8e6882a
Compare
|
So I wasn't having any luck with the NOHUP, maybe it would work somehow, but I got it working by sending GeoServer to a background process and saving the PID for shutdown. |
fc7d160 to
ffe1d21
Compare
* GeoServer will now start in the background and save the PID to data/geoserver/pid/geoserver.pid * GeoServer stdout is redirected to data/geoserver/log/std.out Signed-off-by: Austin Heyne <aheyne@ccri.com>
ffe1d21 to
797d5d6
Compare
README.md
Outdated
|
|
||
| bin/cloud-local.sh start -gs | ||
|
|
||
| You can then use ctrl+c to stop GeoServer, when it finishes shutting down, cloud-local will envoke it's own stop command to shutdown the rest of the cloud. |
There was a problem hiding this comment.
Two quick things: 1) I believe the shutdown instructions are different now that this is a background process; 2) "envoke" -> "invoke". Thanks!
Signed-off-by: Austin Heyne <aheyne@ccri.com>
|
Can you rebase this on master, and fix conflicts, please? |
Signed-off-by: Austin Heyne <aheyne@ccri.com>
Signed-off-by: Austin Heyne <aheyne@ccri.com> Conflicts: .gitignore bin/cloud-local.sh
|
merged master |
…_support Signed-off-by: Austin Heyne <aheyne@ccri.com> Conflicts: README.md bin/cloud-local.sh bin/config.sh
|
Before merging we/I should remove the PID from the file after closing geoserver. This could accidentally kill another process with the same PID later. |
Signed-off-by: Austin Heyne aheyne@ccri.com