Added v22 of keycloak to openapi.jsons, adapted to newer doc versions#34
Added v22 of keycloak to openapi.jsons, adapted to newer doc versions#34MarcoMuellner wants to merge 2 commits intoccouzens:mainfrom
Conversation
MarcoMuellner
commented
Jul 13, 2023
MarcoMuellner
commented
- Paths now have a deprecated option
- Components have a deprecated option
- Added v22
feat: Adapted sections for newer versions of generator
|
Hopefully PRs are okay to this repo. I wasn't quite sure how to deal with the new structure of the doc, to keep the old versions running. This way we should be able to keep both running. |
| static ref TAG_SECTION_SELECTOR_DEPRECATED: Selector = | ||
| Selector::parse("#_paths + .sectionbody > .sect2").unwrap(); | ||
| static ref TAG_SECTION_SELECTOR: Selector = | ||
| Selector::parse("#_resources + .sectionbody > .sect2").unwrap(); |
There was a problem hiding this comment.
As this is CSS selectors, can we combine them with a comma?
"#_paths + .sectionbody > .sect2, #_resources + .sectionbody > .sect2"
Thank you catching this issue and figuring out the solution. I wasn't even aware Keycloak 22.0.0 had released 😅
|
It looks like response bodies have become unlinked from requests. For example, if I search the documentation for How keen are you to get it working with the new HTML changes? Otherwise I can look into it when I have time. Thank you for contributing :) |
|
I would really love to have an openapi.json from the newest doc. It would help me massively. The resulting openapi.json is also pretty weird, this is correct. If you can point me into the correct direction, i'd totally try my hands on it, and see if i can fix it somehow, but my rust is pretty bad. |
|
Some other selectors I'm finding useful whilst looking at this: The path parameters within a section The body parameters within a section This is quite an annoying change, as these HTML tables are quite different in versions <= 21 and version 22. I think the HTML has changed enough, that we should stop generating versions 21 and below. Keep the JSON committed, but don't have the makefile rebuild them. The generator can then focus on 22's HTML and not have to worry about compatibility with old versions. |
|
I'd be good with that :) |
|
Hey, Can you let me know what you think of this? https://raw.githubusercontent.com/ccouzens/keycloak-openapi/version-22/keycloak/22.0.0.json |
|
I'd need to do some more in depth testing of it with an existing keycloak instance, but this looks good to me :) |
2 participants
