Conversation
# Conflicts: # src/lib/services/config/configNode.server.ts
This reverts commit 305ad68.
ComplementaryPogo
force-pushed
the
universal-logger
branch
from
5dd3fa8 to
110c832
Compare
Owner
|
thanks! looking through this, i don't think i like the config option to toggle specific debug logs. this project is probably too small to justify that feature and it would just add unnecessary complexity (i'm assuming claude thought it'd be a good addition?) i'd be down to instead do different debug levels. for now i i'll remove the option you've added and always log checkPerm on debug level |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow logging from server contexts or browser contexts. This is accomplished by default logging to console, but on server startup we set the logging factory, ensuring no potential leakage of sensitive code via vite.