Skip to content

Add Dockerfile, docker-compose, and Makefile#54

Merged
ccev merged 11 commits intoccev:mainfrom
ComplementaryPogo:docker
Jan 31, 2026
Merged

Add Dockerfile, docker-compose, and Makefile#54
ccev merged 11 commits intoccev:mainfrom
ComplementaryPogo:docker

Conversation

@ComplementaryPogo
Copy link
Contributor

No description provided.

@ComplementaryPogo
Copy link
Contributor Author

Should be ready to merge, but please squash-merge since I didn't clean up the commit history.

@ccev
Copy link
Owner

ccev commented Dec 31, 2025

i've added some comments to the code, please look at them. also, please update the readme with instructions on how set this up with docker. thanks!

@ccev
Copy link
Owner

ccev commented Jan 2, 2026

@ComplementaryPogo please add a section to the readme on how to set this up with docker, and rename the the compose file to docker-compose.example.yml and add docker-compose.yml to the .gitignore. then i'm happy to merge and finally look at your other prs. thanks!

@ComplementaryPogo
Copy link
Contributor Author

Addressed all comments. Only other thing is that we could remove the diadem-db mysql instance from docker-compose.example.yml, really depends how turn-key we want the example to be.

@ccev ccev merged commit 983f704 into ccev:main Jan 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants